Our Minecart plugin is making problems and crashed the server a couple of times. I have disabled it until we are able to fix this.
Uncovery Minecraft
Our Minecart plugin is making problems and crashed the server a couple of times. I have disabled it until we are able to fix this.
I recall making an elevator at nether spawn about 3 hours before this post, if that gives any clue. :)
This plugin is probably my favorite feature of the server. I can pull the code from floored’s github repository and look at the issue, or do we not really know what the issue is?
I don’t know exactly what it is. One might have to recompile simply to the latest spigot, but I doubt that since the new versions have all been security fixes.
I am on a trip right now and have very limited time to work on this. Sunday night or Monday I should be able to look into the logfiles though.
I’m going to see if I can build that plugin and try it on my server.
I’ve not used Java in years, so it’s difficult for me to figure out how to turn all those source code files into a project that compiles into a plugin, but after working on that Nether one, I have a better idea.
If I figure anything out I’ll reply here.
I have tested both spigot 1.8.3 and 1.8.7 and I have not seen any issues. Granted, I’m not sure what I’m looking for, and I can’t simulate the load that the Uncovery server might have with lots of users online. I’ve used all the different wool colors, tested many different tracks with different combinations of the colors and also tested a really long (over 2000 blocks) track repeatedly. I’m using the SmartCart.jar that is in Floored’s Github repository. I haven’t been successful at compiling my own version, but since I don’t know what the issue might be, I don’t think any code changes are needed yet.
Thanks a lot. Sorry I did not follow up on this. I will go back to the logfiles and try to get the crash report.
Ok, so here is the log:
[03:42:49] [Server thread/ERROR]: Could not pass event VehicleEnterEvent to SmartCart v0.1.2
org.bukkit.event.EventException
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:310) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at net.minecraft.server.v1_8_R3.Entity.mount(Entity.java:1569) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at net.minecraft.server.v1_8_R3.EntityLiving.mount(EntityLiving.java:1727) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at net.minecraft.server.v1_8_R3.ChunkRegionLoader.loadEntities(ChunkRegionLoader.java:402) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at org.bukkit.craftbukkit.v1_8_R3.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:46) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at org.bukkit.craftbukkit.v1_8_R3.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:1) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at org.bukkit.craftbukkit.v1_8_R3.util.AsynchronousExecutor$Task.finish(AsynchronousExecutor.java:188) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at org.bukkit.craftbukkit.v1_8_R3.util.AsynchronousExecutor$Task.get(AsynchronousExecutor.java:164) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at org.bukkit.craftbukkit.v1_8_R3.util.AsynchronousExecutor.skipQueue(AsynchronousExecutor.java:334) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at org.bukkit.craftbukkit.v1_8_R3.util.AsynchronousExecutor.getSkipQueue(AsynchronousExecutor.java:295) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at org.bukkit.craftbukkit.v1_8_R3.chunkio.ChunkIOExecutor.syncChunkLoad(ChunkIOExecutor.java:16) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at net.minecraft.server.v1_8_R3.ChunkProviderServer.getChunkAt(ChunkProviderServer.java:115) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at net.minecraft.server.v1_8_R3.ChunkProviderServer.getChunkAt(ChunkProviderServer.java:97) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at org.bukkit.craftbukkit.v1_8_R3.CraftWorld.getChunkAt(CraftWorld.java:125) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at org.bukkit.craftbukkit.v1_8_R3.CraftWorld.getBlockAt(CraftWorld.java:89) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at org.bukkit.craftbukkit.v1_8_R3.CraftWorld.getBlockAt(CraftWorld.java:567) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at org.bukkit.Location.getBlock(Location.java:87) ~[spigot.jar:git-Spigot-17fce80-25de1e6]
at net.f85.SmartCart.SmartCartVehicle.isOnRail(SmartCartVehicle.java:82) ~[?:?]
at net.f85.SmartCart.SmartCartListener.onVehicleEnter(SmartCartListener.java:80) ~[?:?]
at sun.reflect.GeneratedMethodAccessor379.invoke(Unknown Source) ~[?:?]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.7.0_79]
at java.lang.reflect.Method.invoke(Method.java:606) ~[?:1.7.0_79]
I’ve looked at the documentation for the VehicleEnterEvent and I’ve looked at the SmartCart code where the event is used. What’s not clear from the error, is did the server fail to send the event to the plugin, or did the plugin fail to handle the event. The way it’s worded implies that it failed to send the event to the plugin, but knowing how error messages can be, it’s possible it’s some sort of failure on the plugin side. There’s nothing complex going on inside the plugin handler of that event though, just looking up the cart in a list and using it if it’s found, or adding it, then using it if it is not found.
If you try enabling the plugin and the error comes back, then we could try adding some messages to the plugin that might help find the issue. I’ll leave a message for Floored to see if he can point me in the right direction to be able to compile the source into a runnable jar. All his Github has is the code, without any project file items or compilation scripts, so attempting to make my own project from the code didn’t work. I’ll try a few other ways of setting up the project and see if any of them are successful too.
Yeah I think it would be great if the plugin could just rather “fail” the action and throw an error instead of taking the whole server down. As of now it seems that the action tries to repeat indefinitely and causes issues.
Yikes! I haven’t been active lately so didn’t see any of this until now. Based on where the error is popping up I’m guessing the plugin is failing to handle the event, because of an exception that’s popping up in the Location.GetBlock() call referenced in the error message.
The first thing I’d try is building it against the latest spigot, since the error seems to be happening inside the Location.GetBlock() call, which is part of the spigot API. There may be some difference between the version the plugin was built against (1.8 R3) vs the version running on the server.
I’ll build it against 1.8.7 tonight and update the repo, hopefully that will help.
Thanks floored!
This is done. Try the new JAR (https://github.com/floored1585/SmartCart/raw/master/bin/SmartCart.jar). If it’s still crashing we’ll probably need to add code to do some validation during the onVehicleEnter event.
OK, great! I uploaded it to the server, should become active in 2 hours, then we will see.
I used a bunch of my train setups earlier today. I didn’t see any issues and the server didn’t crash, so hopefully the changes Floored made have fixed the issue.
Also, thanks floored!