Item Frames and Minecarts

#1 · 2012/11/05, 18:06

I noticed that when I ride my to-storage minecart rail the item frames I use to label my chests, the item frames break. This only happens on one side of the minecart path, and not the other.

Also, it seems as if when they are destroyed, they are blown off to one side. The drops are about two blocks away from the area I had placed the item frames, as if the minecart created a wind.

I tried to take a few screenies, but I'm not sure if it would really prove anything. Also, my storage is not the most impressive, but I'm working on it. XD

I don't know how I'm expected to organize these pictures in the forums, but I'll try :D

#2 · 2012/11/05, 18:08

>:C My images didn't really seem to work. Maybe I should just give the links here:

Picture 1: http://i.imgur.com/sCAe7.png

Picture 2: http://i.imgur.com/U2Qgq.png

Picture 3: http://i.imgur.com/LmBwO.png

#3 · 2012/11/05, 18:57

It almost looks like they're dropped next to the nearest wall behind them. Weird.

#4 · 2012/11/05, 21:52

I think I see the problem.

The code that moves entities out of the path of the minecart was written before ItemFrames were introduced. ItemFrames happen to be an entity, so if they are near the path of an oncoming minecart, they are "moved" out of the way. I think all that is needed to fix the code is an additional check in this function:

https://github.com/mze9412/MinecartMania/blob/master/src/com/afforess/minecartmaniacore/utils/MinecartUtils.java#L422

Perhaps I'll try it in a bit.

#5 · 2012/11/05, 23:08

yes azkedar, that must be the problem.